Fix typos in documentation and helm chart #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cookieParserSecret was always randomized even if hard-coded in values.yaml.
The memory usage seem to be around 250-260MB for each juiceshop instance. Thus, bump to 300MB to be safe.
J12934
approved these changes
May 9, 2023
There was a problem hiding this comment.
Awesome 👍
Thank for for the fixes 🙌
The resource limits are a bit tricky, on some cluster (/machines) juice shop seems to be fine with the existing limit and is always under the 200Mi. But definitly safer to set the default to the higher value to avoid frustration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a mix of several different minor issues (I can split those into separate parts if necessary). Besides the minor typos, the PR contains two noteworthy changes:
cookieParserSecret, such that setting the value in values.yaml had no effect. I've opted to change the referenced key instead of moving thecookieParserSecretaround in values.yaml, as this might be more backwards compatible.