Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate type definition #162

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix duplicate type definition #162

merged 2 commits into from
May 21, 2023

Conversation

stuebingerb
Copy link
Contributor

@stuebingerb stuebingerb commented May 15, 2023

When using the chart in combination with kustomize (e.g. as part of a Flux setup), its parser complains about a duplicate type definition:

{"HelmRelease":{…}, "controller":"helmrelease", "controllerGroup":"helm.toolkit.fluxcd.io", "controllerKind":"HelmRelease",
  "error":"Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
  line 17: mapping key "type" already defined at line 16", "level":"error", "msg":"Reconciler error", "name":"multi-juicer",
  "namespace":"namespace", "reconcileID":"e239b791-71e3-4e94-9ba1-457316e43e55", "ts":"2023-05-15T07:35:19.574Z"}

I've also fixed some minor typos in comments on the way.

@J12934 J12934 added the bug Something isn't working label May 21, 2023
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to fix some typos along the way too :D
Thank you 🙌

@J12934 J12934 merged commit 7e77dfe into juice-shop:main May 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants