Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional labels, annotations and ingress improvements #173

Merged
merged 7 commits into from
Aug 20, 2023

Conversation

zadjadr
Copy link
Contributor

@zadjadr zadjadr commented Jul 27, 2023

Added

  • additionalAnnotations for pods of balancer and juice-shop (useful to add them into service meshes)
  • additionalLabels for ServiceMonitors (useful for adding them to kube-prometheus stack)
  • ingressClassName for ingress class

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 27, 2023
@J12934
Copy link
Member

J12934 commented Aug 9, 2023

Sorry had some busy weeks, but I saw this PR and will try to take a deeper look in the next couple of days 😊

@J12934 J12934 merged commit 0631d72 into juice-shop:main Aug 20, 2023
3 checks passed
J12934 added a commit that referenced this pull request Aug 20, 2023
@J12934
Copy link
Member

J12934 commented Aug 20, 2023

@zadjadr nice seems to be working really nicely :) Thank you for the PR 🙌

I tweaked the names of the values a bit, moved additionalLabels => just labels, i think this is a bit more consistent with the rest of the chart as we often add things to already existing maps without the additional prefix.

Also added annotations to the service monitors and labels to the pods in case somebody needs it in the future :)

@J12934 J12934 added enhancement New feature or request helm Improvements regarding the helm chart labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Improvements regarding the helm chart size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants