Upgrade Qingstor SDK and support private region #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
+ Coverage 59.32% 59.39% +0.07%
==========================================
Files 126 126
Lines 21466 21470 +4
==========================================
+ Hits 12734 12752 +18
+ Misses 7201 7186 -15
- Partials 1531 1532 +1
Continue to review full report at Codecov.
|
davies
reviewed
Jan 17, 2022
| bucketName, zone, host = hostParts[0], "", hostParts[1] | ||
| } else { | ||
| hostParts := strings.SplitN(uri.Host, ".", 3) | ||
| bucketName, zone, host = hostParts[0], hostParts[1], hostParts[2] |
There was a problem hiding this comment.
Should the zone be part of host? Please add an example here.
There was a problem hiding this comment.
This is old logic and has not changed.
endpoint="http://zhjijian-test.sh1a.qingstor.com"
The zone is indeed part of the host.
There was a problem hiding this comment.
I meant the host should be sh1a.qingstor.com, not qingstor.com, right?
There was a problem hiding this comment.
host does not include region doc
davies
changed the title
davies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.