Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 support pvc link #1382

Merged
merged 1 commit into from
Feb 8, 2022
Merged

s3 support pvc link #1382

merged 1 commit into from
Feb 8, 2022

Conversation

zhijian-pro
Copy link
Contributor

Thanks to @joey71765 for testing support!

@zhijian-pro zhijian-pro linked an issue Feb 8, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1382 (c2d4b50) into main (c775a39) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   59.69%   59.67%   -0.03%     
==========================================
  Files         128      128              
  Lines       21681    21688       +7     
==========================================
- Hits        12943    12942       -1     
- Misses       7196     7203       +7     
- Partials     1542     1543       +1     
Impacted Files Coverage Δ
pkg/object/s3.go 42.75% <0.00%> (-1.15%) ⬇️
pkg/chunk/disk_cache.go 79.31% <0.00%> (-0.99%) ⬇️
pkg/meta/sql.go 67.86% <0.00%> (-0.21%) ⬇️
pkg/meta/tkv.go 76.38% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c775a39...c2d4b50. Read the comment docs.

@zhijian-pro zhijian-pro marked this pull request as ready for review February 8, 2022 03:31
@davies davies merged commit 4be6d8a into juicedata:main Feb 8, 2022
@zhijian-pro zhijian-pro deleted the s3_support_pvc_url branch February 8, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support aws s3 by using --endpoint-url
3 participants