Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add Heartbeat configuration #1591

Merged
merged 6 commits into from
Mar 18, 2022
Merged

meta: add Heartbeat configuration #1591

merged 6 commits into from
Mar 18, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Mar 17, 2022

Old sessions can only be cleaned up by old clients.

cmd/flags.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1591 (ea396e7) into main (f78f922) will increase coverage by 0.03%.
The diff coverage is 86.53%.

❗ Current head ea396e7 differs from pull request most recent head da58d30. Consider uploading reports for the commit da58d30 to get more accurate results

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   61.33%   61.36%   +0.03%     
==========================================
  Files         133      133              
  Lines       22424    22439      +15     
==========================================
+ Hits        13753    13770      +17     
+ Misses       7113     7099      -14     
- Partials     1558     1570      +12     
Impacted Files Coverage Δ
pkg/meta/config.go 54.66% <ø> (ø)
pkg/meta/interface.go 55.83% <ø> (ø)
pkg/meta/utils.go 73.17% <ø> (ø)
pkg/meta/sql.go 67.65% <70.58%> (+0.51%) ⬆️
pkg/meta/base.go 72.24% <85.71%> (+0.18%) ⬆️
pkg/meta/tkv.go 76.63% <90.00%> (+0.76%) ⬆️
cmd/flags.go 95.48% <100.00%> (+0.13%) ⬆️
cmd/mount.go 70.08% <100.00%> (+0.13%) ⬆️
pkg/meta/redis.go 73.05% <100.00%> (+0.28%) ⬆️
pkg/chunk/utils_unix.go 73.33% <0.00%> (-20.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78f922...da58d30. Read the comment docs.

@davies davies merged commit cd4947f into main Mar 18, 2022
@davies davies deleted the meta-heartbeat branch March 18, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants