Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: fallback to List only if ListAll is not supported #1623

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Mar 22, 2022

fix #1614

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1623 (a630ef4) into main (f99460e) will increase coverage by 0.01%.
The diff coverage is 32.00%.

❗ Current head a630ef4 differs from pull request most recent head ce87414. Consider uploading reports for the commit ce87414 to get more accurate results

@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
+ Coverage   61.55%   61.56%   +0.01%     
==========================================
  Files         133      133              
  Lines       22474    22489      +15     
==========================================
+ Hits        13833    13845      +12     
- Misses       7077     7081       +4     
+ Partials     1564     1563       -1     
Impacted Files Coverage Δ
pkg/object/cos.go 1.39% <0.00%> (ø)
pkg/object/ibmcos.go 1.29% <0.00%> (ø)
pkg/object/ks3.go 1.22% <0.00%> (ø)
pkg/object/obs.go 0.98% <0.00%> (ø)
pkg/object/oss.go 0.84% <0.00%> (ø)
pkg/object/qingstor.go 1.11% <0.00%> (ø)
pkg/object/qiniu.go 1.58% <0.00%> (ø)
pkg/object/scs.go 2.00% <0.00%> (ø)
pkg/object/sharding.go 69.52% <0.00%> (-1.35%) ⬇️
pkg/sync/sync.go 37.30% <0.00%> (-0.15%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9c186...ce87414. Read the comment docs.

@SandyXSD SandyXSD requested a review from davies March 22, 2022 10:26
@davies davies merged commit 1a49142 into main Mar 22, 2022
@davies davies deleted the object-listall branch March 22, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listAll prefix meta/: not supported
3 participants