Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix snap not released if error occurs when dumping meta #1669

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

SandyXSD
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1669 (87b2953) into main (6f4200f) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
+ Coverage   61.80%   61.83%   +0.02%     
==========================================
  Files         133      133              
  Lines       22607    22607              
==========================================
+ Hits        13973    13978       +5     
+ Misses       7074     7063      -11     
- Partials     1560     1566       +6     
Impacted Files Coverage Δ
pkg/meta/tkv.go 76.62% <0.00%> (-0.06%) ⬇️
pkg/meta/redis.go 73.04% <100.00%> (ø)
pkg/meta/sql.go 67.18% <100.00%> (-0.21%) ⬇️
pkg/vfs/reader.go 84.67% <0.00%> (-1.28%) ⬇️
pkg/chunk/cached_store.go 77.51% <0.00%> (-1.20%) ⬇️
pkg/object/object_storage.go 76.78% <0.00%> (ø)
pkg/sync/sync.go 44.99% <0.00%> (+0.54%) ⬆️
pkg/sync/cluster.go 41.78% <0.00%> (+9.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084b7e0...87b2953. Read the comment docs.

@SandyXSD SandyXSD requested a review from davies March 29, 2022 10:02
@davies davies merged commit 68010fd into main Mar 29, 2022
@davies davies deleted the fix-meta-dump branch March 29, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants