Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use separate metrics per volume #2253

Merged
merged 3 commits into from
Jun 17, 2022
Merged

use separate metrics per volume #2253

merged 3 commits into from
Jun 17, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Jun 16, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #2253 (8d8939c) into main (16adb08) will increase coverage by 0.18%.
The diff coverage is 91.38%.

@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
+ Coverage   61.77%   61.95%   +0.18%     
==========================================
  Files         138      137       -1     
  Lines       25052    25184     +132     
==========================================
+ Hits        15477    15604     +127     
- Misses       7771     7775       +4     
- Partials     1804     1805       +1     
Impacted Files Coverage Δ
cmd/mdtest.go 28.48% <0.00%> (-0.18%) ⬇️
pkg/meta/interface.go 54.92% <ø> (-0.63%) ⬇️
pkg/metric/metrics.go 22.72% <ø> (-9.28%) ⬇️
cmd/gateway.go 86.25% <75.00%> (-1.15%) ⬇️
pkg/chunk/mem_cache.go 86.20% <80.00%> (-2.53%) ⬇️
pkg/meta/sql.go 65.88% <80.00%> (-0.02%) ⬇️
pkg/chunk/cached_store.go 77.39% <93.05%> (+1.01%) ⬆️
pkg/meta/base.go 71.44% <96.15%> (+1.41%) ⬆️
pkg/chunk/disk_cache.go 81.63% <98.14%> (+1.68%) ⬆️
cmd/mount.go 61.95% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16adb08...8d8939c. Read the comment docs.

@davies davies merged commit bfa6ffb into main Jun 17, 2022
@davies davies deleted the fix_vol_metrics branch June 17, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants