Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support database without read-only transaction #2259

Merged
merged 2 commits into from
Jun 17, 2022
Merged

support database without read-only transaction #2259

merged 2 commits into from
Jun 17, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Jun 17, 2022

Vitess is a MySQL proxy, which does not support read-only transactions, we will fallback to default transactions.

close #2237

@davies davies requested a review from SandyXSD June 17, 2022 03:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #2259 (5dba143) into main (32fbe0d) will increase coverage by 0.13%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
+ Coverage   61.74%   61.88%   +0.13%     
==========================================
  Files         138      137       -1     
  Lines       25052    25192     +140     
==========================================
+ Hits        15468    15589     +121     
- Misses       7784     7794      +10     
- Partials     1800     1809       +9     
Impacted Files Coverage Δ
pkg/meta/sql.go 65.85% <52.38%> (-0.33%) ⬇️
cmd/config.go 67.81% <100.00%> (-0.19%) ⬇️
cmd/format.go 60.18% <100.00%> (-0.13%) ⬇️
cmd/objbench.go 62.70% <100.00%> (ø)
pkg/meta/base.go 71.44% <100.00%> (+1.41%) ⬆️
pkg/meta/config.go 55.14% <100.00%> (+1.74%) ⬆️
pkg/meta/redis.go 71.64% <100.00%> (+0.04%) ⬆️
pkg/meta/tkv.go 76.12% <100.00%> (ø)
pkg/metric/metrics.go 22.72% <0.00%> (-9.28%) ⬇️
pkg/vfs/reader.go 77.18% <0.00%> (-3.11%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dabc4...5dba143. Read the comment docs.

@davies davies merged commit 39b52c1 into main Jun 17, 2022
@davies davies deleted the fix_vitess branch June 17, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occurred a DataBase syntax error when run "juicefs format"
2 participants