cmd/info: Fix repeat path info when inode is 1 #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: swj <1186093704@qq.com>
Codecov Report
@@ Coverage Diff @@
## main #2294 +/- ##
=======================================
Coverage 61.88% 61.89%
=======================================
Files 137 137
Lines 25256 25258 +2
=======================================
+ Hits 15630 15633 +3
- Misses 7814 7815 +1
+ Partials 1812 1810 -2
Continue to review full report at Codecov.
|
SandyXSD
reviewed
Jun 23, 2022
| @@ -475,6 +475,9 @@ func GetPaths(m Meta, ctx Context, inode Ino) []string { | |||
| c++ | |||
| paths = append(paths, path.Join(dir, string(e.Name))) | |||
| } | |||
| if inode == 1 { | |||
There was a problem hiding this comment.
Check inode == 1 at the beginning of the GetPaths should be simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: swj 1186093704@qq.com