Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object/OVH: support OVH region #3133

Merged
merged 3 commits into from
Dec 30, 2022
Merged

object/OVH: support OVH region #3133

merged 3 commits into from
Dec 30, 2022

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Dec 29, 2022

ref #3129

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 55.99% // Head: 56.08% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (3d8bbcc) compared to base (638a381).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   55.99%   56.08%   +0.09%     
==========================================
  Files         141      141              
  Lines       32667    32669       +2     
==========================================
+ Hits        18292    18323      +31     
+ Misses      12419    12395      -24     
+ Partials     1956     1951       -5     
Impacted Files Coverage Δ
pkg/object/s3.go 41.22% <0.00%> (-0.24%) ⬇️
pkg/chunk/cached_store.go 71.65% <0.00%> (-0.15%) ⬇️
pkg/meta/redis.go 67.48% <0.00%> (+0.03%) ⬆️
pkg/meta/tkv.go 71.69% <0.00%> (+0.12%) ⬆️
pkg/vfs/handle.go 83.72% <0.00%> (+0.77%) ⬆️
pkg/vfs/reader.go 80.06% <0.00%> (+4.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:1.00 failed:0, passed:12, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3798290957/jobs/6460416659

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro zhijian-pro marked this pull request as ready for review December 29, 2022 06:35
@solracsf
Copy link
Contributor

solracsf commented Dec 29, 2022

Does this work for io endpoints or legacy, or only perf?

s3.de.io.cloud.ovh.net
s3.gra.perf.cloud.ovh.net
s3.uk.cloud.ovh.net

See https://docs.ovh.com/gb/en/storage/object-storage/s3/location/

@zhijian-pro zhijian-pro marked this pull request as draft December 29, 2022 09:58
@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:1.00 failed:0, passed:12, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3799737568/jobs/6462551904

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro zhijian-pro marked this pull request as ready for review December 29, 2022 10:40
@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:1.00 failed:0, passed:12, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3799976068/jobs/6463017045

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

pkg/object/s3.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:1.00 failed:0, passed:12, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/3804410828/jobs/6471616449

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit fe20ebc into main Dec 30, 2022
@davies davies deleted the support_OVH_region branch December 30, 2022 03:16
@p1u3o p1u3o mentioned this pull request Mar 28, 2023
SandyXSD pushed a commit that referenced this pull request Mar 29, 2023
SandyXSD pushed a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants