Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: set encoding type when list object #3244

Merged
merged 2 commits into from
Feb 17, 2023
Merged

object: set encoding type when list object #3244

merged 2 commits into from
Feb 17, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Feb 16, 2023

Object Storage Protocol Encode type config Notes
Azure XML NO PUT failed:The request URL is invalid
NOS XML NO
COS XML YES
OBS XML YES
OSS XML YES listobject api adds EncodingType=url by default
S3 XML YES
TOS JSON YES Since it is a JSON protocol, it is ok not to process it
Ufile JSON NO
Qiniu JSON NO
B2 JSON NO
BOS JSON NO
GS JSON NO
Qingstor JSON NO
Swift JSON NO
SCS JSON NO

These special object stores are not handled:webdav tikv sql sftp redis restful mem file etcd ceph hdfs

close #3216

@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:0.17 failed:10, passed:2, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4192351473/jobs/7267854501

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 55.54% // Head: 55.53% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (ae230a7) compared to base (c3c1d06).
Patch coverage: 13.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   55.54%   55.53%   -0.02%     
==========================================
  Files         142      142              
  Lines       33140    33181      +41     
==========================================
+ Hits        18407    18426      +19     
- Misses      12787    12810      +23     
+ Partials     1946     1945       -1     
Impacted Files Coverage Δ
pkg/object/cos.go 1.06% <0.00%> (-0.05%) ⬇️
pkg/object/ibmcos.go 1.03% <0.00%> (-0.04%) ⬇️
pkg/object/ks3.go 0.91% <0.00%> (-0.04%) ⬇️
pkg/object/obs.go 0.74% <0.00%> (-0.02%) ⬇️
pkg/object/s3.go 40.32% <57.89%> (-0.91%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Mutate Test Report
pkg/object/object_storage_test.go-1-1: score:0.17 failed:10, passed:2, compile error:1, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4200361517/jobs/7286312503

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit e75256a into main Feb 17, 2023
@davies davies deleted the set_encoding_type branch February 17, 2023 05:18
@davies davies added the backport-1.0 Backport to release-1.0 branch label Feb 17, 2023
@SandyXSD SandyXSD mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync stop illegal character code
3 participants