Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set the default schema when remove password from titles #3258

Merged
merged 9 commits into from
Feb 22, 2023

Conversation

zhijian-pro
Copy link
Contributor

fix #3256

pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 55.32% // Head: 55.31% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3dd61e5) compared to base (6225b48).
Patch coverage: 47.61% of modified lines in pull request are covered.

❗ Current head 3dd61e5 differs from pull request most recent head 84f5cef. Consider uploading reports for the commit 84f5cef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
- Coverage   55.32%   55.31%   -0.02%     
==========================================
  Files         142      142              
  Lines       33337    33335       -2     
==========================================
- Hits        18445    18439       -6     
  Misses      12938    12938              
- Partials     1954     1958       +4     
Impacted Files Coverage Δ
cmd/destroy.go 16.96% <0.00%> (ø)
cmd/fsck.go 23.80% <0.00%> (ø)
cmd/gc.go 12.50% <0.00%> (ø)
cmd/main.go 45.62% <ø> (+0.40%) ⬆️
cmd/mdtest.go 26.70% <0.00%> (ø)
cmd/sync.go 50.34% <0.00%> (ø)
pkg/utils/utils.go 66.89% <37.50%> (+2.66%) ⬆️
cmd/config.go 65.27% <100.00%> (ø)
cmd/dump.go 78.66% <100.00%> (ø)
cmd/format.go 57.14% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/main.go Show resolved Hide resolved
@zhijian-pro zhijian-pro changed the title set the default schema when remove password form titles dont set the default schema when remove password form titles Feb 22, 2023
@github-actions
Copy link

Mutate Test Report
pkg/utils/utils_test.go-1-2: score:0.44 failed:5, passed:4, compile error:0, out of coverage:21, skip by comment:1, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4238716424/jobs/7366080298

pkg/utils/utils_test.go-2-2: score:0.25 failed:3, passed:1, compile error:2, out of coverage:22, skip by comment:2, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4238716424/jobs/7366080455

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

Mutate Test Report
pkg/utils/utils_test.go-1-2: score:0.44 failed:5, passed:4, compile error:0, out of coverage:19, skip by comment:1, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4238793710/jobs/7366231484

pkg/utils/utils_test.go-2-2: score:0.17 failed:5, passed:1, compile error:2, out of coverage:18, skip by comment:2, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4238793710/jobs/7366231651

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit 4a8b091 into main Feb 22, 2023
@davies davies deleted the fix_sync_remove_pwd branch February 22, 2023 04:41
@SandyXSD SandyXSD mentioned this pull request Mar 28, 2023
@zhoucheng361 zhoucheng361 changed the title dont set the default schema when remove password form titles don't set the default schema when remove password from titles Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants