Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object/file: warp file storage reader to fix reader length #3405

Merged
merged 9 commits into from
Mar 31, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Mar 29, 2023

close https://github.com/juicedata/web/issues/3522

Storage Service Get Length Method Multipart Upload
File Stream No
GS Stream No
SFTP Stream No
Azure Stream No
HDFS Stream No
Ceph Stream No
Swift Stream No
Jfs Stream No
WebDAV Stream Content-Length is not set success. It's a third-party library bug No
upyun Stream Yes
B2 io.ReadSeeker No
OSS io.LimitedReader Yes
TOS io.LimitedReader Yes
SCS io.LimitedReader Yes
COS io.LimitedReader Yes
BOS io.ReadSeeker Yes
QingStor io.ReadSeeker Yes
OBS io.ReadSeeker Yes
S3 io.Seek Yes
Ufile io.ReadSeeker Yes
EOS S3 Yes
IBM COS S3 Yes
Wasabi S3 Yes
SCW S3 Yes
JSS S3 Yes
Space S3 Yes
KS3 S3 Yes
Minio S3 Yes
OOS S3 Yes
Speed S3 Yes
Qiniu S3 Yes
Etcd io.ReadAll No
Mem io.ReadAll No
Redis io.ReadAll No
SQL io.ReadAll No
TiKV io.ReadAll No

@zhijian-pro zhijian-pro marked this pull request as draft March 29, 2023 14:39
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Patch coverage: 30.95% and project coverage change: +0.33 🎉

Comparison is base (e23cf8a) 55.78% compared to head (de36f23) 56.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3405      +/-   ##
==========================================
+ Coverage   55.78%   56.11%   +0.33%     
==========================================
  Files         148      147       -1     
  Lines       36265    35853     -412     
==========================================
- Hits        20229    20118     -111     
+ Misses      13827    13560     -267     
+ Partials     2209     2175      -34     
Impacted Files Coverage Δ
pkg/sync/sync.go 42.47% <3.33%> (-1.60%) ⬇️
pkg/object/file.go 67.24% <100.00%> (+1.58%) ⬆️
pkg/object/hdfs.go 66.13% <100.00%> (-0.27%) ⬇️
pkg/object/sftp.go 52.61% <100.00%> (+0.27%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/sync/sync.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro marked this pull request as ready for review March 30, 2023 09:49
@zhijian-pro zhijian-pro force-pushed the fix_sync_body_length branch 2 times, most recently from 12b25ff to d1011c0 Compare March 31, 2023 06:06
@davies davies merged commit 940b287 into main Mar 31, 2023
9 checks passed
@davies davies deleted the fix_sync_body_length branch March 31, 2023 12:32
SandyXSD pushed a commit that referenced this pull request Apr 3, 2023
SandyXSD pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants