Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj/sftp: fix size of symlink in sftp #3426

Merged
merged 6 commits into from
Apr 4, 2023
Merged

obj/sftp: fix size of symlink in sftp #3426

merged 6 commits into from
Apr 4, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 3, 2023

No description provided.

@davies davies added the backport-1.0 Backport to release-1.0 branch label Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: +0.09 🎉

Comparison is base (24f2c88) 56.31% compared to head (ebe1a25) 56.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3426      +/-   ##
==========================================
+ Coverage   56.31%   56.40%   +0.09%     
==========================================
  Files         148      148              
  Lines       36143    36161      +18     
==========================================
+ Hits        20353    20396      +43     
+ Misses      13574    13552      -22     
+ Partials     2216     2213       -3     
Impacted Files Coverage Δ
pkg/object/sftp.go 53.79% <89.47%> (+1.17%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhijian-pro
Copy link
Contributor

Need to implement 'SupportSymlink' or you cannot create symlink in a single test.
image

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597011627/jobs/8119193812

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4597110644/jobs/8119415807

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro
Copy link
Contributor

The result of this readdir is strange.
image

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4598393146/jobs/8122391047

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4603358222/jobs/8133297408

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Mutate Test Report
pkg/object/filesystem_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/4603680297/jobs/8133908838

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@zhijian-pro zhijian-pro changed the title fix size of symlink in sftp obj/sftp: fix size of symlink in sftp Apr 4, 2023
@davies davies merged commit cab74a9 into main Apr 4, 2023
12 checks passed
@davies davies deleted the fix_size_of_symlink branch April 4, 2023 05:41
SandyXSD pushed a commit that referenced this pull request Apr 4, 2023
SandyXSD pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants