Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deadlock under concurrent truncate and releases #3457

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 10, 2023

close #3454

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.08 ⚠️

Comparison is base (c80456c) 56.28% compared to head (842b4e3) 56.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3457      +/-   ##
==========================================
- Coverage   56.28%   56.20%   -0.08%     
==========================================
  Files         148      149       +1     
  Lines       36208    36214       +6     
==========================================
- Hits        20379    20355      -24     
- Misses      13614    13649      +35     
+ Partials     2215     2210       -5     
Impacted Files Coverage Δ
pkg/vfs/vfs.go 76.24% <0.00%> (-0.10%) ⬇️
pkg/vfs/handle.go 82.85% <57.14%> (-1.48%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davies davies requested a review from SandyXSD April 10, 2023 09:54
@davies davies added the backport-1.0 Backport to release-1.0 branch label Apr 10, 2023
@SandyXSD SandyXSD merged commit 20630b8 into main Apr 10, 2023
@SandyXSD SandyXSD deleted the fix_truncate_deadlock branch April 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock during concurrent truncate and release
3 participants