Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Android's white background color. #719

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

timbotimbo
Copy link
Collaborator

Description

This removes the white background set in Kotlin, which allows us to experiment with a transparent UnityWidget.
iOS doesn't need any change as this already works.

This should not affect most users, because to see any change you need to both manually configure Unity and adjust the android theme.

See this example of a video widget playing behind Unity to get an idea of the possible results.
(The video is started on a small delay to show the black flash, which is a flutter bug with AndroidView.)

Screen_Recording_20221119-193603.mp4

See #190 (comment) for more details.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@fiercepark
Copy link

@timbotimbo How did you get the transparent unity background color on android? I set the camera color to black with transparency 0 as well as "render over native ui" and this does not work for me, it still shows the black background.

@timbotimbo
Copy link
Collaborator Author

timbotimbo commented Dec 4, 2022

@fiercepark
Check step 3 of the original comment here #190 (comment).

I needed to adjust the android styles.xml to allow transparency.

@jesseburstrom

This comment was marked as off-topic.

@timbotimbo timbotimbo merged commit 46a2350 into juicycleff:master Feb 2, 2023
@timbotimbo timbotimbo deleted the android_transparent_view branch February 5, 2023 13:54
@hehe605715432
Copy link

hey!
it worked well with @timbotimbo instructed at first.
However, the project stops working after enable HDR.
It works on unity version 2021.3.29f1c1.

I would really appreciate any help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants