Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the webviewx package with webview_flutter_web. #761

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

timbotimbo
Copy link
Collaborator

@timbotimbo timbotimbo commented Feb 8, 2023

Description

This replaces the webviewx package with webview_flutter_web. These are only used on the web platform.

The webviewx package relies on webview_flutter: ^2.0.13, which is currently at 4.0.2. This causes issues when a different webview is used in an app using a UnityWidget. #738

A workaround was to use dependency overrides in pubspec.yaml.

dependency_overrides:
  webview_flutter: [VERSION_YOU_NEED]

A recent webview_flutter_web update (0.2.2) makes it compatible with the Unity export.
To make things future-proof, let's change this to a webview that isn't abandoned.

Testing

The example project seems to work as expected.
I'd love feedback from anyone using Unity in a web project to see how this performs.

@Ahmadre Given that you added web, maybe you can take a look.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@drsmile1001
Copy link

How to help merge this?

Copy link
Collaborator

@RoyalCoder88 RoyalCoder88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, everything is fine and passed all the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants