Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the class "callstack" in the math directory? #26

Open
LogicalError opened this issue Jul 9, 2014 · 3 comments
Open

Why is the class "callstack" in the math directory? #26

LogicalError opened this issue Jul 9, 2014 · 3 comments

Comments

@LogicalError
Copy link

Title says it all

@juj
Copy link
Owner

juj commented Jul 9, 2014

Do you have a recommendation where to locate it better? I am hesitant to adding new directories in the source tree and the Math/ directory already contains all the logging functions as well (MathLog.h/.cpp) and callstack is very closely related to logging.

@LogicalError
Copy link
Author

I would probably put it into a separate directory called logging, it doesn't have anything (directly) to do with math ...
... why are you hesitant to add a new directory? is there a downside? ;)

@juj
Copy link
Owner

juj commented Jul 9, 2014

Having more directories means having more things to have to remember ("Did I have to #include "Math/Foo.h" or #include "Logging/Foo.h" or something else?"), and people have requested to not use absolute include directories so that users don't need to add multiple include directives i.e. -IMathGeoLib/ + -IMathGeoLib/Math + -IMathGeoLib/Geometry/. This means that the include directories in code have relative paths like #include "../../Math/Foo.h" and it looks a bit ugly.

I don't want to change existing code file locations, because that will definitely break code for all users if they need to change include files around. So it's simplest to keep the directory structure that currently exists, and not add new ones (unless there would be a large bulk of files to add in a new directory, that'd make organization much clearer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants