Add test that scales masters #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazypower
reviewed
Jun 26, 2017
tests/20-charm-validation.py
Outdated
| self.deployment.sentry.wait() | ||
| for master in self.masters: | ||
| output, rc = master.run('grep server: /home/ubuntu/config') | ||
| self.assertTrue(rc == 0) |
There was a problem hiding this comment.
I see that you add 2 masters here but dont check if the IP matches the recently added units. The test could potentially report a false positive as we aren't checking for the server: key when there are no master units. So what happens if the config just isn't updated? or what if it has the older ip address from the original server? There are two scenarios I can think of that would cause this to pass when the behavior is actually bad.
There was a problem hiding this comment.
The server IP on the configs should be the IP of the loadbalancer. And you are right that we should make sure the loadbalancer points to the new masters as soon as they come up.
The latest commit does both checks. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests this issue: https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/311
A potential fix for the above issue is here: kubernetes/kubernetes#48054