This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Add internal-lb config option #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2022
nobuto-m
reviewed
Apr 7, 2022
samuelallan72
changed the title
addyess
suggested changes
Apr 20, 2022
This is ultimately a configuration option for cloud provider openstack. This new option is passed to the openstack integrator interface, to be used by charm-kubernetes-control-plane to set config for cloud-provider-openstack.
|
Note: don't merge yet; I'm still testing the latest changes. |
|
Ok, testing finished from my end. Ready for another review pass. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ultimately a configuration option for cloud provider openstack.
This new option is passed to the openstack integrator interface,
to be used by charm-kubernetes-control-plane
to set config for cloud-provider-openstack.
Related PRs:
Launchpad bug: #1877692