This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Refactor installation dependency chain #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I conferred with @marcoceppi this morning about the charm-tools and charm dependency chain and the future facing move to snap delivery. We're currently pressed as we cant deliver software via snaps inside docker unless we're running systemd amenities. Docker doesn't play well with running an init, so we're at an impass. Here's the current packaging notes: - Instal charm-tools from pypi. This will always be up to date with the latest stable release of charm-tools - For now, install the charm command from apt, until we have the delivery pipeline sorted - any derivative works should actively try not to unpin versioned dependencies such as pyyaml. So a simple `pip install` vs `pip install -U` will suffice. This build was tested as a base for cwrbox and resolves the dependency chain issues that surfaced on 8/30/2016
|
Seems reasonable. 👍 |
|
Built and everything appears to be working as expected. |
| @@ -3,26 +3,29 @@ set -e | |||
| HOME=/home/ubuntu | |||
|
|
|||
| # Add tims awesome PPA for the 2.0 bleeding edge tooling | |||
| sudo add-apt-repository -y ppa:tvansteenburgh/ppa | |||
There was a problem hiding this comment.
Thank you for removing this!
|
This change seems reasonable to me. I encountered a problem with a downlevel version of amulet today in my tests of the etcd charm. I am hoping the pip version is more recent. |
|
+1 LGTM |
This was referenced Sep 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I conferred with @marcoceppi this morning about the charm-tools and
charm dependency chain and the future facing move to snap delivery.
We're currently pressed as we cant deliver software via snaps inside
docker unless we're running systemd amenities. Docker doesn't play well
with running an init, so we're at an impass. Here's the current
packaging notes:
latest stable release of charm-tools
delivery pipeline sorted
dependencies such as pyyaml. So a simple
pip installvspip install -Uwill suffice.This build was tested as a base for cwrbox and resolves the dependency
chain issues that surfaced on 8/30/2016