/charmbox

Refactor installation dependency chain #55

Merged
merged 1 commit into from Sep 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chuckbutler @johnsca @mbruzek
@chuckbutler
Contributor

chuckbutler commented Sep 1, 2016

I conferred with @marcoceppi this morning about the charm-tools and
charm dependency chain and the future facing move to snap delivery.

We're currently pressed as we cant deliver software via snaps inside
docker unless we're running systemd amenities. Docker doesn't play well
with running an init, so we're at an impass. Here's the current
packaging notes:

  • Instal charm-tools from pypi. This will always be up to date with the
    latest stable release of charm-tools
  • For now, install the charm command from apt, until we have the
    delivery pipeline sorted
  • any derivative works should actively try not to unpin versioned
    dependencies such as pyyaml. So a simple pip install vs pip install -U will suffice.

This build was tested as a base for cwrbox and resolves the dependency
chain issues that surfaced on 8/30/2016
@chuckbutler
Refactor installation dependency chain 
I conferred with @marcoceppi this morning about the charm-tools and
charm dependency chain and the future facing move to snap delivery.

We're currently pressed as we cant deliver software via snaps inside
docker unless we're running systemd amenities. Docker doesn't play well
with running an init, so we're at an impass. Here's the current
packaging notes:

 - Instal charm-tools from pypi. This will always be up to date with the
   latest stable release of charm-tools
 - For now, install the charm command from apt, until we have the
   delivery pipeline sorted
 - any derivative works should actively try not to unpin versioned
   dependencies such as pyyaml. So a simple `pip install` vs `pip
   install -U` will suffice.

This build was tested as a base for cwrbox and resolves the dependency
chain issues that surfaced on 8/30/2016
df6643f
@johnsca
Owner

johnsca commented Sep 1, 2016

Seems reasonable. 👍
@johnsca
Owner

johnsca commented Sep 1, 2016

Built and everything appears to be working as expected.
install-review-tools.sh
@@ -3,26 +3,29 @@ set -e
HOME=/home/ubuntu
# Add tims awesome PPA for the 2.0 bleeding edge tooling
-sudo add-apt-repository -y ppa:tvansteenburgh/ppa
@mbruzek

mbruzek Sep 1, 2016

Contributor

Thank you for removing this!

@mbruzek
Contributor

mbruzek commented Sep 1, 2016

This change seems reasonable to me. I encountered a problem with a downlevel version of amulet today in my tests of the etcd charm. I am hoping the pip version is more recent.
@mbruzek
Contributor

mbruzek commented Sep 1, 2016

+1 LGTM

@mbruzek mbruzek merged commit 38f6700 into juju-solutions:master Sep 1, 2016

This was referenced Sep 1, 2016

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment