This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Add support for changing request data #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
reviewed
Nov 17, 2022
| toggle_flag(self.expand_name('ready'), self.is_ready) | ||
| if self.is_ready and was_ready and self.is_changed: |
There was a problem hiding this comment.
ready.changed seems it should be set when
not self.is_ready() and was_ready or self.is_ready() and not was_ready
is that the intent of ready.changed?
i'm confused what this flag does?
There was a problem hiding this comment.
This code was taken straight from interface-openstack-integration here
The ready.changed flag indicates that the relation data has changed, while the charm was and still is ready.
Seems weird to me too but I'm trying to keep it consistent with the established pattern. shrugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for https://bugs.launchpad.net/bugs/1915557
For the provides side: Add the
all_requestsproperty so that azure-integrator can access requests that have already been processed, and refresh them with new cloud data.For the requires side: Watch for cloud data changes and set the
endpoint.azure.ready.changedflag so that kubernetes-control-plane and kubernetes-worker can react to it.