This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Fix edge case where interface can get stuck unjoined #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is apparently an edge case where the changed and broken handlers can get queued in a hook and fire in that order leading to no subsequent changed handlers being queued and the flags all being left cleared. It's safer overall to include joined in the handler conditions so that even if something strange happens, it will sort itself out into the stable state.
tvansteenburgh
approved these changes
Aug 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is apparently an edge case where the changed and broken handlers can get queued in a hook and fire in that order leading to no subsequent changed handlers being queued and the flags all being left cleared (and thus leading to stuck charms on either end). It's safer overall to include joined in the handler conditions so that even if something strange happens, it will sort itself out into the stable state.
Fixes lp:1841259