Add lb_enabled to the relation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2023
addyess
approved these changes
Jan 6, 2023
addyess
pushed a commit
to charmed-kubernetes/interface-openstack-integration
that referenced
this pull request
Jan 12, 2023
* Implement support for loadbalancer enabling * Add lb_enabled property to requires side * Ensure return value from lb_enabled is always bool Co-authored-by: Nikolay Vinogradov <nikolay.vinogradov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for https://bugs.launchpad.net/bugs/1995746 and https://bugs.launchpad.net/bugs/1990494
The openstack-integrator charm will gain a new config option,
lb_enabled, to control whether LoadBalancer support should be enabled in openstack-cloud-controller-manager (OCCM). The OCCM config is rendered by kubernetes-control-plane, so,lb_enabledneeds to be sent over the relation.Thanks to @nikolayvinogradov for the initial work on this!