This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
State changes and set_installed to spark_started #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def get_private_ip(self): | ||
| conv = self.conversation() | ||
| return conv.get_remote('private-address') |
There was a problem hiding this comment.
Minor nit, the name implies that it will always return an IP address, which is generally not what private-address is. Really, we need to get the DNS charm worked into our deployments and ensure we always return resolvable host names. Anyway, not really a blocker.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed states:
related => joined
available => ready
Also changed set_installed and clear_installed to: set_spark_started and clear_spark_started