This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Handle LZO support in HadoopBase (if available) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention this builds off of PR9, but that incorrectly assumed jujuresources.install would verify/fetch hadoop-lzo-$arch for me. Since jr.install doesn't do that, the resource would never be installed. This commit handles verify/fetch hadoop-lzo-$arch in HadoopBase.init just like we do with the hadoop-$arch resource. |
johnsca
added a commit
that referenced
this pull request
Nov 3, 2015
Handle LZO support in HadoopBase (if available)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LZO is distributed as a separate resource (due to licensing). If the resource is defined in a resources.yaml, fetch it along with our main hadoop resource and try to install it during HadoopBase.install_hadoop().
This is a bit hackey, as it lets jujuresources.resource_path throw a keyerror if hadoop-lzo-$arch is not defined in resources.yaml. It would be better if jujuresources had a "resource_exists" method so we didn't have to overload resource_path. Alas, if it is a valid resource key, we proceed with fetch/verify and ultimately install.