Update resources scripts #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynerva
reviewed
Jun 26, 2018
| @@ -24,15 +24,13 @@ mkdir -p ${TEMPORARY_DIRECTORY} | |||
| resources/repackage-easyrsa.sh | |||
|
|
|||
| export OS=$(get_os) | |||
| export ARCHITECTURES=${ARCHITECTURES:-"amd64"} #"amd64 arm arm64 ppc64le" | |||
| export ARCHITECTURES=${ARCHITECTURES:-"amd64 arm64"} #"amd64 arm arm64 ppc64le" | |||
There was a problem hiding this comment.
Why no s390x here? Is upstream not shipping s390x packages?
There was a problem hiding this comment.
Indeed there is no s390x for etcd: https://github.com/coreos/etcd/releases needed for flannel here: https://github.com/juju-solutions/kubernetes-jenkins/blob/master/resources/repackage-flannel.sh#L32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this yet. Lets wait for after the 1.10 release.
Updates the resources scripts because some paths have changes and also we do not build k8s enymore, we have k8s in snaps.