Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Changed flag is sometimes cleared, sometimes not #6

Open
johnsca opened this issue Sep 9, 2020 · 0 comments
Open

Changed flag is sometimes cleared, sometimes not #6

johnsca opened this issue Sep 9, 2020 · 0 comments

Comments

@johnsca
Copy link
Contributor

johnsca commented Sep 9, 2020

The changed flag (which is also currently undocumented) can be cleared by the layer if fetch is called and either fails or there is not a new image available. This can happen if an upgrade-charm hook is fired, leading to the flag sometimes automatically clearing itself and sometimes not, which is inconsistent and prone to bugs.

Since the flag isn't even documented yet, I'm inclined to changing it so that it will always have to be explicitly cleared by the charm code and documenting that behavior.

knkski added a commit to canonical/bundle-kubeflow that referenced this issue Oct 2, 2020
knkski added a commit to canonical/bundle-kubeflow that referenced this issue Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant