/matrix

[WIP] Added more actions, and improved action handling. #4

Closed
wants to merge 5 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@petevg
@petevg
Collaborator

petevg commented Oct 19, 2016

Plan can now select from actions that have arguments other than a unit.

@bcsaller @johnsca
@petevg
Added more actions, and improved action handling. 
Plan can now select from actions that have arguments other than a unit.
3b462a5
matrix/plugins/glitch/actions.py
@@ -19,21 +22,23 @@ class _Actions(dict, metaclass=Singleton):
functions.
"""
- def decorate(self, func):
+ def decorate(self, object_type):
@petevg

petevg Oct 19, 2016

Collaborator

Whoops. That's remaining from when I was passing in object type explicitly, with the double nested decorators. Should be "func"

petevg added some commits Oct 19, 2016

@petevg
Fixed syntax errors and other obvious mistakes. 
Update to WIP branch to fix gross errors. Tests still failing due to a
None sneaking in under circumstances under which it should not be
possible for a None to sneak around our type checking, though :-/
05adedf
@petevg
Hooray for passing tests! 
Still some bugs to work out in some of the actions, but the basic
structure of the code is once again sound.
284dd44
@petevg
Cleaned up TODOs. 
Fixed a few. Cleaned up some that weren't relevant. Dropped in a couple
more that reflect work that I still want to do this week.
ba98ebe
@petevg
Added Kevin's suggestion for networking mischief to the TODOs in acti… 
…ons.py
a5f69e1

@petevg petevg closed this Oct 20, 2016

@petevg petevg deleted the feature/glitch-more-actions branch Oct 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment