This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
[WIP] Added more actions, and improved action handling. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan can now select from actions that have arguments other than a unit.
pengale
commented
Oct 19, 2016
| @@ -19,21 +22,23 @@ class _Actions(dict, metaclass=Singleton): | |||
| functions. | |||
|
|
|||
| """ | |||
| def decorate(self, func): | |||
| def decorate(self, object_type): | |||
There was a problem hiding this comment.
Whoops. That's remaining from when I was passing in object type explicitly, with the double nested decorators. Should be "func"
Update to WIP branch to fix gross errors. Tests still failing due to a None sneaking in under circumstances under which it should not be possible for a None to sneak around our type checking, though :-/
Still some bugs to work out in some of the actions, but the basic structure of the code is once again sound.
Fixed a few. Cleaned up some that weren't relevant. Dropped in a couple more that reflect work that I still want to do this week.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan can now select from actions that have arguments other than a unit.
@bcsaller @johnsca