Tweak payload for expose change parameters #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commits will be introducing some breaking changes so a version bump was required.
SimonRichardson
approved these changes
Sep 9, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the recent design change where expose settings can be specified per endpoint, the changes introduced by #66 had to be revised to adhere to the new design.
Because of these changes, the description for an expose change would now become a multi-line string. To this end, the signature of the
Descriptionmethod for theChangeinterface has been modified to return a[]stringinstead so that the caller can appropriately render the description items. This change breaks backwards compatibility so a new (v2.0.0) branch has been created and the package version on master has been bumped to 3.