Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"functions" is no longer the new name for actions #459

Closed
timClicks opened this issue Apr 21, 2020 · 1 comment
Closed

"functions" is no longer the new name for actions #459

timClicks opened this issue Apr 21, 2020 · 1 comment

Comments

@timClicks
Copy link
Contributor

Actions are now actions again. We should un-deprecate action_get and friends.

charm-helpers/charmhelpers/core/hookenv.py

Lines 987 to 994 in 2521285

@deprecate("moved to function_get()", log=log)
def action_get(key=None):
"""
.. deprecated:: 0.20.7
Alias for :func:`function_get`.
Gets the value of an action parameter, or all key/value param pairs.
"""

odufourc added a commit to odufourc/charm-helpers that referenced this issue Nov 23, 2021
@odufourc
undeprecate action-* functions (juju#459)
87e0b60 
From LP #1926317 also, the action functions should not be set as
deprecated anymore. It also set instead the function-get/set/fail
as deprecated.
It fixes misleading and unnecessary warning logs.
fnordahl added a commit that referenced this issue Nov 24, 2021
@fnordahl
Merge pull request #655 from odufourc/action_undeprecated
d16a0a3 
undeprecate action-* functions (#459)
@fnordahl
Copy link
Contributor

Fixed by #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timClicks @fnordahl