Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrpe.write will add max_check_attempts: null which will cause nagios to break #564

Closed
guoqiao opened this issue Feb 2, 2021 · 0 comments · Fixed by #565
Closed

nrpe.write will add max_check_attempts: null which will cause nagios to break #564

guoqiao opened this issue Feb 2, 2021 · 0 comments · Fixed by #565

Comments

@guoqiao
Copy link
Contributor

guoqiao commented Feb 2, 2021

In commit 198c0e3 ,
a new kwarg max_check_attempts=None was introduced to nrpe.Check class.
However, it doesn't check the None condition, which will always render max_check_attempts: null in check cfg and cause nagios to break with latest charmhelpers.

We need to add None check to ensure max_check_attempts only be rendered when it's not None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant