Catch NoNetworkBinding for VIPs in resolve_address #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was one network_get_primary_address call left which was not protected by NoNetworkBinding in resolve_address when clustering is in use and VIPs are set. This change catches that last case. Also, confirmed there are no other cases.
fnordahl
approved these changes
Mar 13, 2019
openstack-gerrit
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Mar 14, 2019
Please review and merge CH change first: juju/charm-helpers#298 Change-Id: I6960e6860cdaf6f7c293558aadea557a227357dc
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Mar 14, 2019
* Update charm-openstack-dashboard from branch 'master'
- Sync charm helpers for NoNetworkBinding fix
Please review and merge CH change first:
juju/charm-helpers#298
Change-Id: I6960e6860cdaf6f7c293558aadea557a227357dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one network_get_primary_address call left which was not
protected by NoNetworkBinding in resolve_address when clustering is in
use and VIPs are set.
This change catches that last case. Also, confirmed there are no other
cases.