Reuse connection in MySQLHelper #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a connection exists in MySQLHelper (self.connection) then reuse it rather than creating a new one.
gnuoy
changed the title
thedac
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
I am +1 on this. I also think this resolves LP Bug #1866164
https://bugs.launchpad.net/charm-mysql-innodb-cluster/+bug/1866164
thedac
changed the title
thedac
approved these changes
Jul 13, 2020
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 14, 2020
* Update charm-mysql-innodb-cluster from branch 'master'
- Merge "Reuse database connections."
- Reuse database connections.
This PR should only speed up charm hook execution be reusing database
connections. Tested with ~35 client units connected to the shared-db
relation and execution time of db_router_respond dripped from >5mins
to ~1min.
Tested with juju/charm-helpers#478
Change-Id: I9cb4937207fcd0b8045b8b67f63c5e9397decfb4
openstack-mirroring
pushed a commit
to openstack/charm-mysql-innodb-cluster
that referenced
this pull request
Jul 14, 2020
This PR should only speed up charm hook execution be reusing database connections. Tested with ~35 client units connected to the shared-db relation and execution time of db_router_respond dripped from >5mins to ~1min. Tested with juju/charm-helpers#478 Change-Id: I9cb4937207fcd0b8045b8b67f63c5e9397decfb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a connection exists in MySQLHelper (self.connection) then reuse
it rather than creating a new one.