Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add leader and status new hooks #129
Conversation
perrito666
added some commits
Apr 27, 2015
|
LGTM |
|
|
rogpeppe
reviewed
May 20, 2015
hooks/hooks.go
| + ConfigChanged Kind = "config-changed" | ||
| + UpgradeCharm Kind = "upgrade-charm" | ||
| + Stop Kind = "stop" | ||
| + ActionRequested Kind = "action-requested" // TODO: remove in charm v5, DEPRECATED |
rogpeppe
May 20, 2015
Owner
We could probably remove this now, as we've long since moved to charm v5 and beyond.
|
LGTM with one thought. |
added a commit
that referenced
this pull request
May 20, 2015
perrito666
merged commit 2b813ba
into
juju:v6-unstable
May 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
perrito666 commentedMay 11, 2015
These hooks are required for:
Leader election, these are alredy defined but in the wrong place
inside juju core.
Health status, we add an update-status hook.