Add leader and status new hooks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2015 12:30
These hooks are required for: Leader election, these are alredy defined but in the wrong place inside juju core. Health status, we add an update-status hook.
|
LGTM |
|
👍 thank you! |
| ConfigChanged Kind = "config-changed" | ||
| UpgradeCharm Kind = "upgrade-charm" | ||
| Stop Kind = "stop" | ||
| ActionRequested Kind = "action-requested" // TODO: remove in charm v5, DEPRECATED |
There was a problem hiding this comment.
We could probably remove this now, as we've long since moved to charm v5 and beyond.
|
LGTM with one thought. |
perrito666
pushed a commit
that referenced
this pull request
May 20, 2015
Add leader and status new hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hooks are required for:
Leader election, these are alredy defined but in the wrong place
inside juju core.
Health status, we add an update-status hook.