Expose charm version on archive #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jujubot
added a commit
to juju/juju
that referenced
this pull request
Feb 11, 2019
#9722 ## Description of change When deploying local charms that contain a `version` file, the charm version details are updated with the contents of that file. This was not the case when attempting to deploy charms from the charm store which results in the version details not being included in the `juju status` output. This PR bumps the sha for the `charm.v6` dependency (see: juju/charm#269) which provides a helper charm archive method for fetching the version of a charm and updates the relevant code to populate the charm version field prior to persisting its details to the store. ## QA steps ```console $ juju deploy vault $ juju status vault --format yaml | grep charm-version charm-version: 220f0ee ``` Note: you should get the same output when deploying a local charm that includes a `version` file. ## Bug reference https://bugs.launchpad.net/juju/+bug/1812227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the work required for fixing https://bugs.launchpad.net/juju/+bug/1812227. Juju needs to retrieve the VCS version (e.g git sha) for charm archives fetched from the charmstore.
In order to avoid changing the
Charminterface that would inevitably break other dependencies, the PR exposes aVersion()method on theCharmArchivetype. The actual juju code that fetches the archive (using the charmrepo pkg) already casts the result to acharm.CharmArchiveso this change allows us to fetch the version with minimal impact to other users of the package.