Add method to bundle for reporting presence of overlays #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
approved these changes
Jul 25, 2019
| @@ -15,8 +15,10 @@ import ( | |||
| type Bundle interface { | |||
| // Data returns the contents of the bundle's bundle.yaml file. | |||
| Data() *BundleData | |||
| // Data returns the contents of the bundle's README.md file. | |||
| // ReadMe returns the contents of the bundle's README.md file. | |||
|
@jameinel Yes, I will be following up with a charmstore PR that uses the new helper method. |
|
|
achilleasa
deleted the
add-method-to-bundle-for-reporting-presence-of-overlays
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Bundle interface with a new method
ContainsOverlaysthat users of the charm package can use to check whether the bundle they just obtained using one of the Read helpers did in fact contain one or more overlay blocks that were not actually parsed as the Read helpers do not work with multi-document bundles.This new functionality will be leveraged by the charmstore code to reject uploads for multi-doc bundles.