Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action-Schema JSON validation #4

Merged
merged 3 commits into from Jun 13, 2014
Merged

Action-Schema JSON validation #4

merged 3 commits into from Jun 13, 2014

Commits on Jun 13, 2014

  1. Action-Schema JSON validation 

    charm.ActionSpec now has a ValidateParams method which accepts an
unmarshaled JSON document, and validates it.  If it is valid, the
method returns true; otherwise, it returns false and a list of
errors returned by gojsonschema.

Additionally, the charm cleanse() function will now reject schemas containing $ref and $schema keys:
 - These keys typically cause HTTP GET's on remote schemas, which we want to avoid.
 - They are also known to have a potential non-terminated recursion in the current version of http://github.com/binary132/gojsonschema.
    @binary132
    binary132 committed Jun 13, 2014
    Configuration menu
    Copy the full SHA
    2449929 View commit details
    Browse the repository at this point in the history

  2. Tweaked prohibitedKeys to map[string]bool, removed gopkg dep

    @binary132
    binary132 committed Jun 13, 2014
    Configuration menu
    Copy the full SHA
    6fe68a5 View commit details
    Browse the repository at this point in the history

  3. Tweaked naming to be more accurate for temp ActionSpec.

    @binary132
    binary132 committed Jun 13, 2014
    Configuration menu
    Copy the full SHA
    42e3326 View commit details
    Browse the repository at this point in the history