New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List command returns a "not logged in message" when not logged in. #190

Open

dgnball wants to merge 1 commit into juju:master from dgnball:no_interactive_login_for_list

dgnball commented Sep 6, 2018

This fixes #136

The charm list command now behaves the same way as the charm whoami command when you are not logged in:

$GOPATH/bin/charm list
not logged into https://api.jujucharms.com/charmstore
$GOPATH/bin/charm whoami
not logged into https://api.jujucharms.com/charmstore

It also checks whether the URL is valid and I have added an extra unit test to make sure I have coverage.


          List command returns a "not logged in message" when not logged in.

21eeb91

Contributor

jujugui commented Sep 6, 2018

please test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment