/charmstore

Avoid internal compiler error on gccgo #582

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bz2 @jujugui @cherylj
@bz2
Contributor

bz2 commented Mar 23, 2016

Something in the handling of constants by gccgo 4.9 blows up
when trying to compile api.go:

In function ‘v5.WillIncludeMetadata.pN59_gopkg_in_juju_charmstore_v5_unstable_internal_v5.ReqHandler’:
go1: internal compiler error: in fold_binary_loc, at fold-const.c:10124

Adjusting the switch statement to look at type rather than compare
against literals avoids the issue.
Avoid internal compiler error on gccgo 
Something in the handling of constants by gccgo 4.9 blows up
when trying to compile api.go:

In function ‘v5.WillIncludeMetadata.pN59_gopkg_in_juju_charmstore_v5_unstable_internal_v5.ReqHandler’:
go1: internal compiler error: in fold_binary_loc, at fold-const.c:10124

Adjusting the switch statement to look at type rather than compare
against literals avoids the issue.
462934d
@jujugui
Member

jujugui commented Mar 23, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/charmstore/1668/
Test PASSed.
@cherylj

cherylj commented Mar 23, 2016

juju-core bug: https://bugs.launchpad.net/juju-core/+bug/1561023
@cherylj

cherylj commented Mar 23, 2016

LGTM
@bz2
Contributor

bz2 commented Mar 23, 2016

:shipit:
@jujugui
Member

jujugui commented Mar 23, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge

@jujugui jujugui merged commit dab0340 into juju:v5-unstable Mar 23, 2016
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment