New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the expand-id API. #76
Conversation
Test PASSed. |
|
||
// Retrieve all the entities with the same base URL. | ||
var docs []mongodoc.Entity | ||
if err := h.store.DB.Entities().Find(bson.M{"baseurl": id}).Select(bson.M{"_id": 1}).All(&docs); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using bson.D rather than bson.M in general. It's equivalent, but just slightly more lightweight at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Good stuff. LGTM with a few minor suggestions above. |
Test PASSed. |
Test PASSed. |
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge |
No description provided.