cmd: remove dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependencies on juju version and osenv packages. Unexport VersionCommand.
|
LGTM |
| UsagePrefix string | ||
| // UsagePrefix should be set when the SuperCommand is | ||
| // actually a subcommand of some other SuperCommand; | ||
| // if NotifyRun is called, it name will be prefixed accordingly, |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests and remove juju-core dependencies.
Specifically, it no longer depends on the juju version
package (SuperCommandParams now has a Version field
and a NotifyRun callback) or the osenv package (Log now
contains a DefaultConfig field).