[JUJU-390] Add DisplayName to the Machine description #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cderici
changed the title
manadart
requested changes
Jan 24, 2022
|
|
jujubot
added a commit
to juju/juju
that referenced
this pull request
Jan 28, 2022
#13645 #### Description This allows the machines (usually provided by OCI or MAAS) to be able to transfer their `DisplayName` fields through a migration. Fixes: [LP #1954969](https://bugs.launchpad.net/juju/+bug/1954969). Requires: - [x] juju/description#102 to land. - [x] #13653 to land. #### QA Steps You'll need either Oracle OCI or MAAS controllers for this one. (Other providers don't use display name) I tested it with the OCI, like as follows (I used the compartment&tenancy ids from within the cloud-city): ```sh juju bootstrap --config compartment-id=$OCID_COMPARTMENT oci-canonical oci-test-controller2 juju bootstrap --config compartment-id=$OCID_COMPARTMENT oci-canonical oci-test-controller1 juju add-model --config compartment-id=$OCID_COMPARTMENT test-model1 juju deploy ubuntu ``` Note the machine `Inst Id` in juju status, or do `db.instanceData.find().pretty()` in mongodb and look for the `display-name` field. ```sh juju migrate test-model1 oci-test-controller2 ``` 1. Migration should be successful, 2. After the migration is complete you should be able to see the same id in the juju status or the db. #### Notes & Discussion This PR also includes temporary code that will be removed before the PR lands: - go.mod for external changed dependency (description pkg), and - provider/oci/environ.go for quick fix to allow the PR to run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
DisplayNamefield for a machine to transfer its display name through the migration.It is a pre-requisite for this PR on juju for fixing the LP #1954969.
QA steps
Added the
display-namefield in the unit tests within thecloudinstance_test.go, so the following should succeed.$ go test