Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial Actions documentation #117

Merged
merged 1 commit into from Jan 19, 2015
Merged

initial Actions documentation #117

merged 1 commit into from Jan 19, 2015

Conversation

johnweldon
Copy link
Contributor

Initial docs derived from the Actions DRAFT specification for Juju Actions.

@binary132
Copy link
Contributor

I'll be addressing my hacker related concerns in a PR against juju/juju.

However, let it be known that I really think juju/docs needs a Hackers section! I would've gotten involved in the project much sooner if I'd known it was so open to collaboration. 😃

@binary132 binary132 mentioned this pull request Jun 8, 2014
@marcoceppi
Copy link
Contributor

Some initial comments. It's not clear yet, but we're working on dev/stable branch setup for the docs. Currently master is "stable" but this pull request has reminded me that we need to finish that setup @evilnick

Some formatting feedback, don't use $ to denote commands. Also, it's been shown that using

```LANG
code
```

Is better than the 4 space indented blocks. Where LANG is the syntax highlighting you'd want.

@evilnick
Copy link
Member

ping! Are there any updates on this, as i'd like to get it added soon.

@johnweldon
Copy link
Contributor Author

Yeah; sorry Nick; I've been remembering that I needed to finish this up
soon myself. :)

Thanks for the reminder.

John Weldon

On Mon, Jun 30, 2014 at 1:29 PM, evilnick notifications@github.com wrote:

ping! Are there any updates on this, as i'd like to get it added soon.


Reply to this email directly or view it on GitHub
#117 (comment).

@binary132
Copy link
Contributor

This should land with #221 in step just after it.

src/en/actions.md needs to be added to src/navigation.tpl, perhaps after "working with Units".

@binary132
Copy link
Contributor

#221 adds documentation for Charm authors including details of the usage of Action tools:

  • action-get
  • action-set
  • action-fail

@marcoceppi
Copy link
Contributor

Is this ready for review?

@evilnick
Copy link
Member

It has diverged from the master branch, so it needs looking at

evilnick added a commit that referenced this pull request Jan 19, 2015
initial Actions documentation
@evilnick evilnick merged commit 25491d5 into juju:master Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants