Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc on how to change an application's series #2019

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

hmlanigan
Copy link
Member

to Getting things done.

can be found [here][appendix].

```
$ mongo-update-app-series.sh -m default -a ghost -s xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we package this up as a juju plugin? It could even be a plugin that follow the 2.3 semantics such that if you're on 2.3 it works per docs and if earlier it behaves the same way once the plugin is there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the cards right now, however it's open to discussion in the future.

@@ -0,0 +1,113 @@
Title: Change an application' series post deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is really about how to do it pre-2.3 maybe title this in that way? Otherwise just use the normal documentation? So this turns into "how to change an application series pre-juju2.3" or something ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been going back and forth on this one myself. Changed.

Copy link
Member

@evilnick evilnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style changes.

Also, this document only refers to versions prior to 2.3, in which case it would be better to target to the 2.2 branch of the docs rather than master .


## Overview

When deploying an application with juju you can specify the series it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

When deploying an application with Juju you can specify the series it
will use, or use the default series for the model. Prior to Juju 2.3,
any units which are subsequently added to the application always use
the series specified at deployment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -0,0 +1,117 @@
Title: Change an application's series pre-juju2.3

# Change an application's series pre-juju2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "(prior to 2.3)" works slightly better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

the application would always use the series specified at deployment
when adding units with no way to change it.

With juju 2.3 or later it's possible let juju know you'd like to add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With version 2.3 or later, it's possible let Juju know..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

units with a different series moving forward by running the command:
`juju update-series <application> <series>`

Here we'll cover the manual steps on how to do this pre-juju2.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...how to do this with earlier versions of the software."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


## Prerequisites

1. Check that the current charm revision in use for the application supports the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make a proper numbered list in markdown, these should be indented (two spaces is usual) and always start with a "1."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

## Prerequisites

1. Check that the current charm revision in use for the application supports the
series you wish to use in the future. This checked on in the juju charm store.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juju Charm Store

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


## Update

Start by switching to the juju controller where the changes will happen using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juju controller

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is juju capitalized here and not other places?

@evilnick
Copy link
Member

evilnick commented Sep 6, 2017

Thanks for this. Let me know if you want to make the changes and retarget to 2.2 or we can take the information from this PR and do it if you prefer

@hmlanigan hmlanigan force-pushed the app-series-update branch 2 times, most recently from c55da95 to 8281523 Compare October 4, 2017 18:15
@hmlanigan
Copy link
Member Author

I think I've accomplished the rebase to 2.2?

@hmlanigan hmlanigan changed the base branch from master to 2.2 October 4, 2017 18:25
@evilnick
Copy link
Member

evilnick commented Oct 4, 2017

It looks like you have 😄
I will go over this again in the morning. thanks!

@hmlanigan
Copy link
Member Author

@evilnick, please review together with PR 2045, they are separate but go together.

@evilnick
Copy link
Member

evilnick commented Oct 5, 2017

there were still a few things that weren't updated, but I will add the fixes

@evilnick evilnick added the 2.2 label Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants