Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joyent config #68

Closed
wants to merge 3 commits into from
Closed

Joyent config #68

wants to merge 3 commits into from

Conversation

arosales
Copy link
Contributor

Instructions on how to set up configure environments.yaml to provision instances on Joyent's cloud. Note, I rebuilt the docs as I needed to updated the navigation to include Joyent config. Please let me know if this was the correct thing to do or if the sync to the site will automatically do this.

@evilnick
Copy link
Member

As far as I can work out from this commit and the workings of the
'improved' docs, this won't work.

You need to explicitly add your new source doc (presumably config-joyent.md)
git add src/config-joyent.md

Then you need to regenerate the html docs.
Then you need need to also add the generated doc:

git add htmldocs/config-joyent.html

then you need to commit and make a PR.
Except we shouldn't really land anything else until someone sorts out the
previous 2 PRs which will otherwise be lost.

On Mon, Apr 21, 2014 at 10:07 AM, Antonio notifications@github.com wrote:

Instructions on how to set up configure environments.yaml to provision
instances on Joyent's cloud. Note, I rebuilt the docs as I needed to
updated the navigation to include Joyent config. Please let me know if this
was the correct thing to do or if the sync to the site will automatically

do this.

You can merge this Pull Request by running

git pull https://github.com/arosales/docs joyent-config

Or view, comment on, or merge it at:

#68
Commit Summary

  • Add Joyent config to navigation page.
  • Corrections and updates to Joyent config. Rebuilt docs to render new
    html pages.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/68
.

Nick Veitch
nick.veitch@canonical.com

@arosales
Copy link
Contributor Author

Nick
Thanks for the review. Ya, it seems my config-joyent.md page is missing. I will add it now . . .

-thanks,
Antonio

@arosales
Copy link
Contributor Author

Branch updated, ready for 2nd review.

-thanks,
Antonio

@castrojo
Copy link
Contributor

This won't work, you only need to add the page and then add it to the navigation template, not manually add it to every file! Here's an example: #68

@evilnick
Copy link
Member

Is that the correct place to put the image? Do we still put CSS and other
resources in htmldocs? i think we need to make that clear in the
instructions too.

On Mon, Apr 21, 2014 at 6:05 PM, Jorge Castro notifications@github.comwrote:

This won't work, you only need to add the page and then add it to the
navigation template, not manually add it to every file! Here's an example:
#68 #68

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/68#issuecomment-40952891
.

Nick Veitch
nick.veitch@canonical.com

@castrojo
Copy link
Contributor

Screenshot location will need to be resolved, I filed this: #71

@arosales
Copy link
Contributor Author

Note this pull is resolved in https://github.com/juju/docs/pull/70and #71

Thanks Jorge and Nick for the feedback.

-Thanks,
Antonio

@marcoceppi marcoceppi closed this Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arosales @evilnick @castrojo @marcoceppi