Print the stack trace when formatting with %+v #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the stack trace when formatting with %+v
|
Thanks for this. LGTM but I'll leave the final verdict to @howbazaar |
| } | ||
|
|
||
| // helper for Format | ||
| type unformatter Err |
There was a problem hiding this comment.
I don't understand why this is necessary?
There was a problem hiding this comment.
@howbazaar because otherwise fmt.Fprintf(s, "%#v", e) would yield an infinite recursion.
Any better idea to achieve the same formatting of %#v without re-entering the Format method?
|
moving to #28 due to organization membership change |
jujubot
added a commit
that referenced
this pull request
May 9, 2017
Print the stack trace when formatting with %+v Discovered in: http://dave.cheney.net/2016/06/12/stack-traces-and-the-errors-package Code based on: https://github.com/pkg/errors With a minor but hackish change to still allow %#v to print the structure fields, in order to not break the principle of least surprise. Let me know if there is a better way to strip a type of an interface or invoke the default %#v behaviour on a type that implements fmt.Formatter. --- NOTE: this is the continuation of #26. I no longer work for cesanta and thus cannot address comments in the original PR. #26 received the green light from @mjs, and had an open question by @howbazaar, whom I replied to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in:
http://dave.cheney.net/2016/06/12/stack-traces-and-the-errors-package
Code based on:
https://github.com/pkg/errors
With a minor but hackish change to still allow
%#vto print the structure fields, in order to not break the principle of least surprise. Let me know if there is a better way to strip a type of an interface or invoke the default%#vbehaviour on a type that implementsfmt.Formatter.