Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Local charms icons not properly shown in the GUI canvas #3067

Closed
ionutbalutoiu opened this issue Jul 11, 2017 · 8 comments
Closed

Local charms icons not properly shown in the GUI canvas #3067

ionutbalutoiu opened this issue Jul 11, 2017 · 8 comments
Labels
bug discussion external An issue where the root cause is a service that GUI interacts with.

Comments

@ionutbalutoiu
Copy link

ionutbalutoiu commented Jul 11, 2017

I have a local Juju controller on MAAS with GUI enabled and I deployed a couple of local charms.
The charms icons are broken in the GUI canvas and this is what I see: http://balutoiu.com/ionut/icons.png

If I do an inspect element on the charm box from the canvas and open the icon url into another tab, I see that icon is properly fetched from the Juju controller.

Moreover, when using Firefox, there is no issue and icons are properly shown in the GUI canvas.

Versions of the tools used:

  • Juju 2.2.1
  • Google Chrome 59.0.3071.115
  • Firefox 54.0.1
@hatched hatched added this to the loyal la forge milestone Jul 11, 2017
@hatched
Copy link
Contributor

hatched commented Jul 11, 2017

Thanks for the report! We'll look into this shortly.

@hatched hatched modified the milestones: loyal la forge - 2.8.0, massive morn Aug 1, 2017
@frankban frankban modified the milestones: naive nog, massive morn Aug 24, 2017
@frankban
Copy link
Member

Related, from https://bugs.launchpad.net/juju/+bug/1712269

Due this Chrome https://www.chromestatus.com/feature/5669008342777856 feature. Juju icons are not loaded at all.

Chrome tries load images:

https://user-admin%40local:foobarpasswords@10.10.10.1:17070/model/e61120bf-9b6d-43e1-8ae4-f4bf5b31ffd1/charms?url=local:xenial/any-charm&icon=1

This reults (blocked:origin) error on Chrome.

@ionutbalutoiu
Copy link
Author

Any update on this bug ? I'm using 2.2.4-xenial-amd64 right now and it icons are still not visible in Google Chrome.

@deephack1982
Copy link

deephack1982 commented Sep 26, 2017

I just commented on this related issue. https://github.com/juju/juju-gui/issues/1262#issuecomment-332166336

Can confirm that it works correctly in Firefox.

@hatched
Copy link
Contributor

hatched commented Oct 3, 2017

As this requires extensive changes in Juju to provide us with a different way to securely fetch the local charm assets, any updates to this may be a long time coming. I consider this to be a regression in Chrome and hopefully they will fully revert the change in time.

@hatched hatched modified the milestones: naive nog, __flickering future__ Oct 3, 2017
@frankban
Copy link
Member

frankban commented Oct 4, 2017

Yes I agree. We need to implement a macaroon based auth for getting charm files from the controller. This means adding macaraq logic for local users as well. While this is something that we'd like to implement for other auth-related reasons as well, we'll have to find a slot for this.

@rmescandon
Copy link

Any news on this thing?

@hatched
Copy link
Contributor

hatched commented Apr 15, 2019

I see that the old issue was closed. I've created a new one that can be used to track this issue in Juju https://bugs.launchpad.net/juju/+bug/1824887

@hatched hatched added the external An issue where the root cause is a service that GUI interacts with. label Apr 15, 2019
@clagom clagom closed this as completed Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug discussion external An issue where the root cause is a service that GUI interacts with.
Development

No branches or pull requests

6 participants